fix: [notify] Rewrite notification item delegate with paint method #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored notification item delegate to use direct painting instead of widget-based approach for better performance and visual consistency. Key changes include: - Removed widget-based item delegate implementation - Added custom paint methods for background, icon, text and buttons - Implemented mouse event handling for close button and action buttons - Added text layout handling with proper wrapping and elision - Introduced constants for layout metrics and spacing - Added new roles and data structure for action button info The new implementation provides smoother scrolling and consistent styling while reducing memory usage by eliminating widget creation for each item. Log: Refactor notification item delegate to use paint-based rendering Bug: https://pms.uniontech.com/bug-view-272445.html
deepin-mozart
approved these changes
Jan 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepin-mozart, Kakueeen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored notification item delegate to use direct painting instead of widget-based
approach for better performance and visual consistency. Key changes include:
The new implementation provides smoother scrolling and consistent styling while
reducing memory usage by eliminating widget creation for each item.
Log: Refactor notification item delegate to use paint-based rendering
Bug: https://pms.uniontech.com/bug-view-272445.html